Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(align-deps): migrate set-version command #1948

Merged
merged 5 commits into from
Oct 21, 2022
Merged

refactor(align-deps): migrate set-version command #1948

merged 5 commits into from
Oct 21, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 20, 2022

Description

Migrates the set-version command.

Test plan

As with the init command, the set-version is currently also only available for React Native packages.

  • Verify that align-deps fails if the configuration is missing: 
    cd packages/babel-preset-metro-react-native
node ../align-deps/lib/cli.js --set-version 0.68
  • Verify that align-deps fails if the configuration is incomplete: 
    cd packages/metro-config
node ../align-deps/lib/cli.js --set-version 0.68
  • align-deps will migrate while updating requirements: 
    cd packages/test-app
node ../align-deps/lib/cli.js --set-version 0.68

@tido64 tido64 added the feature: align-deps This is related to align-deps label Oct 20, 2022
@tido64 tido64 mentioned this pull request Oct 20, 2022
Closed
24 tasks
afoxman
afoxman reviewed Oct 20, 2022
View reviewed changes
packages/align-deps/src/helpers.ts Show resolved Hide resolved
packages/align-deps/src/preset.ts Outdated Show resolved Hide resolved
packages/align-deps/src/preset.ts Show resolved Hide resolved
packages/align-deps/src/preset.ts Show resolved Hide resolved
packages/align-deps/src/commands/setVersion.ts Show resolved Hide resolved
packages/align-deps/src/commands/setVersion.ts Show resolved Hide resolved
packages/align-deps/src/commands/setVersion.ts Outdated Show resolved Hide resolved
@tido64 tido64 merged commit c9c8236 into microsoft:main Oct 21, 2022
@tido64 tido64 deleted the tido/align-deps/set-version branch October 21, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afoxman afoxman afoxman approved these changes

@kelset kelset Awaiting requested review from kelset

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
feature: align-deps This is related to align-deps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @afoxman