Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace dep-check in guides #1978

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 27, 2022

@tido64 tido64 added documentation Improvements or additions to documentation feature: align-deps This is related to align-deps labels Oct 27, 2022
@tido64 tido64 mentioned this pull request Oct 27, 2022
24 tasks
@kelset
Copy link
Contributor

kelset commented Oct 27, 2022

I think we want to wait for this until we are ready for the full 2.0 rollout

@tido64
Copy link
Member Author

tido64 commented Oct 27, 2022

I think we want to wait for this until we are ready for the full 2.0 rollout

Yup, it's listed under "release" in #1890

Copy link
Contributor

@afoxman afoxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for updating the guides!

Is there a place for --vigilant anywhere in the guides? I can't recall if you retired that flag or not, but I remember some "vigilant" code in the recent rounds of PRs for align-deps.

@tido64
Copy link
Member Author

tido64 commented Oct 27, 2022

Looks good to me, thanks for updating the guides!

Is there a place for --vigilant anywhere in the guides? I can't recall if you retired that flag or not, but I remember some "vigilant" code in the recent rounds of PRs for align-deps.

The only instances I can find after this change is in the Dependency Management. But we've added notes there instead since it's the original dep-check RFC.

@tido64 tido64 merged commit f719496 into microsoft:main Nov 11, 2022
@tido64 tido64 deleted the tido/update-docs branch November 11, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature: align-deps This is related to align-deps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants