Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dep-check): update react-native-svg package for RN 0.69+ #2022

Closed
wants to merge 1 commit into from

Conversation

Aure77
Copy link

@Aure77 Aure77 commented Nov 8, 2022

Description

react-native-svg@^13.5.0 support react native 0.69+ new architecture build (Fabric).
See: https://github.com/software-mansion/react-native-svg/releases/tag/v13.0.0

* react-native-svg@^13.5.0 support react native 0.69+ new architecture
@kelset
Copy link
Contributor

kelset commented Nov 8, 2022

thanks for submitting, I just want @tido64 to chime in because I think that at least we'll have to duplicate this into the align-deps dependency.

@tido64
Copy link
Member

tido64 commented Nov 8, 2022

I've been following the progress of react-native-svg a bit. Backwards compatibility breaks often, which is worrying to me. I intended to wait a bit until the 13.x branch is more stable before checking how viable it is. We will need to upgrade internally to make sure we can recommend it.

@Aure77 is this blocking you?

@Aure77
Copy link
Author

Aure77 commented Nov 8, 2022

No it's not blocking, but I made a custom profile to support that:

module.exports = {
  "0.70": {
    svg: {
      name: "react-native-svg",
      version: "^13.4.0"
    }
  }
};

But maybe a confusing part of rnx-dep-check is why higher semver version of a dependency is considered as "non-compliant" for a version of RN ?
For example, I manually updated my dep in package.json with upper version, but rnx-dep-check suggest me to downgrade (without custom profile):

$ rnx-dep-check --vigilant 0.70
...
-     "react-native-svg": "^13.5.0",
+     "react-native-svg": "^12.3.0",
...

Would an option to skip higher dep versions could be helpful ? or customProfiles should address it ?

@tido64
Copy link
Member

tido64 commented Nov 8, 2022

But maybe a confusing part of rnx-dep-check is why higher semver version of a dependency is considered as "non-compliant" for a version of RN ?

semver-wise, a major version introduces breaking changes. If dep-check allowed greater versions, it could inadvertently recommend versions that break compatibility. To make things simpler, the versions that dep-check recommend are just the values that are set in the profiles.

Would an option to skip higher dep versions could be helpful ? or customProfiles should address it ?

customProfiles is the solution here if you want to use other versions than what the built-ins recommend.

@kelset
Copy link
Contributor

kelset commented Nov 8, 2022

( btw @Aure77 just as an headsup, be aware that we are in the process of finalizing the next version of dep-check, align-deps: #1890 )

@tido64
Copy link
Member

tido64 commented Nov 17, 2022

( btw @Aure77 just as an headsup, be aware that we are in the process of finalizing the next version of dep-check, align-deps: #1890 )

FYI, this has happened. Over the next weeks, we're going to telling people to start migrating to align-deps. We will no longer be updating dep-check.

react-native-svg 13.6.0 also recently dropped, fixing compatibility issues with older versions. I'm inclined to recommend that we consider 13.6.0 starting with 0.70. You won't be able to get Fabric + autolinking working in 0.69 anyway. I'm currently trying to get people to test internally.

@tido64
Copy link
Member

tido64 commented Jan 13, 2023

We're bumping react-native-svg to 13.7.0 in the 0.71 profile: #2032

I will close this one now. Thanks for your contribution 😄

@tido64 tido64 closed this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants