-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dep-check): update react-native-svg package for RN 0.69+ #2022
Conversation
* react-native-svg@^13.5.0 support react native 0.69+ new architecture
thanks for submitting, I just want @tido64 to chime in because I think that at least we'll have to duplicate this into the align-deps dependency. |
I've been following the progress of react-native-svg a bit. Backwards compatibility breaks often, which is worrying to me. I intended to wait a bit until the 13.x branch is more stable before checking how viable it is. We will need to upgrade internally to make sure we can recommend it. @Aure77 is this blocking you? |
No it's not blocking, but I made a custom profile to support that:
But maybe a confusing part of
Would an option to skip higher dep versions could be helpful ? or |
semver-wise, a major version introduces breaking changes. If dep-check allowed greater versions, it could inadvertently recommend versions that break compatibility. To make things simpler, the versions that dep-check recommend are just the values that are set in the profiles.
|
FYI, this has happened. Over the next weeks, we're going to telling people to start migrating to
|
We're bumping react-native-svg to 13.7.0 in the 0.71 profile: #2032 I will close this one now. Thanks for your contribution 😄 |
Description
react-native-svg@^13.5.0 support react native 0.69+ new architecture build (Fabric).
See: https://github.com/software-mansion/react-native-svg/releases/tag/v13.0.0