Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-native-host): bump C++ language standard to C++20 #2867

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Dec 1, 2023

Description

react-native has updated Folly and bumped C++ language standard. This will break 0.65 and below.

See also microsoft/react-native-test-app#1714.

Test plan

In react-native-test-app, verify that nightly builds:

git checkout tido/3.0
npm run set-react-version nightly
yarn clean
yarn
# Copy changes into node_modules/@rnx-kit/react-native-host/ReactNativeHost.podspec
cd example
rm ios/Podfile.lock
pod install --project-directory=ios
yarn ios

Verify that 0.66 still works:

npm run set-react-version 0.66
yarn clean
yarn
# Copy changes into node_modules/@rnx-kit/react-native-host/ReactNativeHost.podspec
cd example
rm ios/Podfile.lock
pod install --project-directory=ios
yarn ios

This will unfortunately break `react-native` versions 0.65 and below,
but is neccessary to support 0.74 and above.
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a few attempts but I was able to fully verify that it all works, in both nightlies and 0.66.

Let's :shipit:

@tido64 tido64 merged commit f727aa5 into main Dec 4, 2023
12 checks passed
@tido64 tido64 deleted the tido/rnh/nightly branch December 4, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: sdk This is related to 1RN SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants