Skip to content

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Mar 17, 2025

Description

indexPageMiddleware is no longer needed/used in 0.79

Test plan

In RNTA:

yarn set-react-version 0.79
yarn
cd example
yarn start

This should not crash:

/~/node_modules/connect/index.js:87
  if (typeof handle.handle === 'function') {
                    ^

TypeError: Cannot read properties of undefined (reading 'handle')
    at Function.use (/~/node_modules/connect/index.js:87:21)
    at exports.runServer (/~/node_modules/metro/src/index.flow.js:148:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async rnxStart (/~/node_modules/@rnx-kit/cli/lib/start.js:152:28)

@tido64 tido64 requested a review from Saadnajmi March 17, 2025 16:17
@github-actions github-actions bot added the feature: cli This is related to CLI label Mar 17, 2025
@tido64 tido64 merged commit 9d78635 into main Mar 18, 2025
12 checks passed
@tido64 tido64 deleted the tido/cli/fix-0.79 branch March 18, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: cli This is related to CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants