Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-extractor] Report an error to indicate that "import()" types are not supported #1867

Merged

Conversation

javier-garcia-meteologica
Copy link
Contributor

Makes explicit that ImportType nodes are not supported.
Related to #1050

@iclanton iclanton changed the title Throw error for unsupported ImportType nodes [api-extractor] Throw error for unsupported ImportType nodes May 13, 2020
@octogonz octogonz changed the title [api-extractor] Throw error for unsupported ImportType nodes [api-extractor] Report an error to indicate that "import()" types are not supported May 16, 2020
@msftclas
Copy link

msftclas commented May 16, 2020

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@octogonz octogonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few changes to improve the error message

@octogonz
Copy link
Collaborator

@javier-garcia-meteologica please sign the CLA so we can merge this. Thanks!

@octogonz octogonz merged commit db88b2b into microsoft:master May 19, 2020
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 19, 2020
Please note api-extractor does not support `import("<pkg>")`.

See microsoft/rushstack#1867

The mixins are left to be broken as there is no easy workaround.
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 19, 2020
Please note api-extractor does not support `import("<pkg>")`.

See microsoft/rushstack#1867

The mixins are left to be broken as there is no easy workaround.
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
Please note api-extractor does not support `import("<pkg>")`.

See microsoft/rushstack#1867

The mixins are left to be broken as there is no easy workaround.
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
Please note api-extractor does not support `import("<pkg>")`.

See microsoft/rushstack#1867

The mixins are left to be broken as there is no easy workaround.
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
Please note api-extractor does not support `import("<pkg>")`.

See microsoft/rushstack#1867

The mixins are left to be broken as there is no easy workaround.
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
Please note api-extractor does not support `import("<pkg>")`.

See microsoft/rushstack#1867

The mixins are left to be broken as there is no easy workaround.
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
raymondfeng added a commit to loopbackio/loopback-next that referenced this pull request May 20, 2020
alep007 pushed a commit to alep007/loopback-next that referenced this pull request Oct 21, 2020
Please note api-extractor does not support `import("<pkg>")`.

See microsoft/rushstack#1867

The mixins are left to be broken as there is no easy workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants