-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-extractor] Report an error to indicate that "import()" types are not supported #1867
Merged
octogonz
merged 4 commits into
microsoft:master
from
javier-garcia-meteologica:error_on_import_type
May 19, 2020
Merged
[api-extractor] Report an error to indicate that "import()" types are not supported #1867
octogonz
merged 4 commits into
microsoft:master
from
javier-garcia-meteologica:error_on_import_type
May 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-garcia-meteologica
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
May 13, 2020 13:36
iclanton
changed the title
Throw error for unsupported ImportType nodes
[api-extractor] Throw error for unsupported ImportType nodes
May 13, 2020
javier-garcia-meteologica
force-pushed
the
error_on_import_type
branch
from
May 14, 2020 09:18
f27b422
to
c9b73d1
Compare
octogonz
changed the title
[api-extractor] Throw error for unsupported ImportType nodes
[api-extractor] Report an error to indicate that "import()" types are not supported
May 16, 2020
octogonz
approved these changes
May 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few changes to improve the error message
@javier-garcia-meteologica please sign the CLA so we can merge this. Thanks! |
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 19, 2020
Please note api-extractor does not support `import("<pkg>")`. See microsoft/rushstack#1867 The mixins are left to be broken as there is no easy workaround.
7 tasks
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 19, 2020
Please note api-extractor does not support `import("<pkg>")`. See microsoft/rushstack#1867 The mixins are left to be broken as there is no easy workaround.
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
Please note api-extractor does not support `import("<pkg>")`. See microsoft/rushstack#1867 The mixins are left to be broken as there is no easy workaround.
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
Please note api-extractor does not support `import("<pkg>")`. See microsoft/rushstack#1867 The mixins are left to be broken as there is no easy workaround.
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
Please note api-extractor does not support `import("<pkg>")`. See microsoft/rushstack#1867 The mixins are left to be broken as there is no easy workaround.
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
Please note api-extractor does not support `import("<pkg>")`. See microsoft/rushstack#1867 The mixins are left to be broken as there is no easy workaround.
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
raymondfeng
added a commit
to loopbackio/loopback-next
that referenced
this pull request
May 20, 2020
alep007
pushed a commit
to alep007/loopback-next
that referenced
this pull request
Oct 21, 2020
Please note api-extractor does not support `import("<pkg>")`. See microsoft/rushstack#1867 The mixins are left to be broken as there is no easy workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes explicit that ImportType nodes are not supported.
Related to #1050