Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Remove unnecessary decouple checks #5078

Closed
wants to merge 2 commits into from

Conversation

L-Qun
Copy link
Contributor

@L-Qun L-Qun commented Jan 13, 2025

Summary

- if (localProject && !this.decoupledLocalDependencies.has(dependency)) {
+ if (localProject) {

I think this logic is redundant because if we haven't declared a package in decoupledLocalDependencies and the package is a local project, it must be dependent in a workspace manner.

@iclanton
Copy link
Member

This check is actually necessary. There are two scenarios where this will cause a problem. 1 - a non-workspaces repo and 2 - a case where you specify a range that is satisfiable by the local version of the package, but you explicitly want a published copy.

@iclanton iclanton closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants