Add support for using all cores on windows machines with -p max flag #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octogonz
reviewed
Mar 16, 2018
| parameterLongName: '--parallelism', | ||
| parameterShortName: '-p', | ||
| key: 'COUNT', | ||
| description: 'Specify the number of concurrent build processes.' | ||
| description: 'Specify the number of concurrent build processes' | ||
| + ` A value of 'max' can be used to achieve the maximum default parallelism.` | ||
| + ' If omitted, the parallelism will be based on the number of CPU cores.' |
There was a problem hiding this comment.
Maybe clarify:
'The value "max" can be specified to indicate the number of CPU cores. If this parameter omitted, the default value depends on the operating system and number of CPU cores." #Resolved
octogonz
reviewed
Mar 16, 2018
| parameterLongName: '--parallelism', | ||
| parameterShortName: '-p', | ||
| key: 'COUNT', | ||
| description: 'Specify the number of concurrent build processes.' | ||
| description: 'Specify the number of concurrent build processes' | ||
| + ` A value of 'max' can be used to achieve the maximum default parallelism.` |
There was a problem hiding this comment.
' [](start = 29, length = 1)
English language uses double-quotes #Resolved
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change was made recently to rush to make it such that the default parallelism is set to be 1 less than the number of cores on windows. This was to address some performance issues windows users were experiencing when trying to do other tasks while a rush build was running.
However, in CI environments, we want the maximum amount of available parallelism to get faster builds. This change introduces a 'max' argument to the -p flag that always sets the paralellism to equal the number of cores on the CPU.