enums.md: Rename from_i32 to try_from_i32 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common convention in Rust when converting from one type to another in a fallible way (i.e., when returning a Result,) is to name the function "try_from_*" instead of "from_*" which is used for infallible conversions (we also see this same pattern in the From and TryFrom traits.) This lets the programmer know at a glance that they're dealing with a value or a Result.
atifaziz
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common convention in Rust when converting from one type to another in a fallible way (i.e., when returning a Result,) is to name the function
try_from_*instead offrom_*, which is used for infallible conversions (we also see this same convention in theFromandTryFromtraits.) This lets the programmer know at a glance that they're dealing with a value or a Result.