Don't remove invocations.

microsoft · Sep 23, 2020 · 25140f1 · 25140f1
1 parent cc242f7
commit 25140f1
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 65 deletions.
diff --git a/src/Sarif/Visitors/GitHubIngestionVisitor.cs b/src/Sarif/Visitors/GitHubIngestionVisitor.cs
@@ -20,14 +20,6 @@ public override Run VisitRun(Run node)
  this.artifacts = node.Artifacts;
  this.threadFlowLocations = node.ThreadFlowLocations;
 
- // GitHub does not support submitting invocation objects. Invocations
- // contains potentially sensitive environment details, such as 
- // account names embedded in paths. Invocations also store 
- // notifications of catastrophic tool failures, however, which 
- // means there is current no mechanism for reporting these to
- // GitHub users in context of the security tab.
- node.Invocations = null;
-
  if (node.Results != null)
  {
  int errorsCount = 0;

diff --git a/src/Test.UnitTests.Sarif/Test.UnitTests.Sarif.csproj b/src/Test.UnitTests.Sarif/Test.UnitTests.Sarif.csproj
@@ -22,13 +22,11 @@
  <None Remove="TestData\GitHubIngestionVisitor\ExpectedOutputs\ThreadFlowLocations.sarif" />
  <None Remove="TestData\GitHubIngestionVisitor\ExpectedOutputs\TooManyResults.sarif" />
  <None Remove="TestData\GitHubIngestionVisitor\ExpectedOutputs\WithArtifacts.sarif" />
- <None Remove="TestData\GitHubIngestionVisitor\ExpectedOutputs\WithInvocation.sarif" />
  <None Remove="TestData\GitHubIngestionVisitor\Inputs\Fingerprints.sarif" />
  <None Remove="TestData\GitHubIngestionVisitor\Inputs\NonErrorResults.sarif" />
  <None Remove="TestData\GitHubIngestionVisitor\Inputs\ThreadFlowLocations.sarif" />
  <None Remove="TestData\GitHubIngestionVisitor\Inputs\TooManyResults.sarif" />
  <None Remove="TestData\GitHubIngestionVisitor\Inputs\WithArtifacts.sarif" />
- <None Remove="TestData\GitHubIngestionVisitor\Inputs\WithInvocation.sarif" />
  <None Remove="TestData\GitHubIngestionVisitor\RelatedLocationMessage.sarif" />
  <None Remove="TestData\InsertOptionalDataVisitor\ExpectedOutputs\CoreTests-Absolute_TextFiles.sarif" />
  <None Remove="TestData\InsertOptionalDataVisitor\ExpectedOutputs\CoreTests-Relative_All.sarif" />
@@ -91,13 +89,11 @@
  <EmbeddedResource Include="TestData\GitHubIngestionVisitor\ExpectedOutputs\NonErrorResults.sarif" />
  <EmbeddedResource Include="TestData\GitHubIngestionVisitor\ExpectedOutputs\ThreadFlowLocations.sarif" />
  <EmbeddedResource Include="TestData\GitHubIngestionVisitor\ExpectedOutputs\WithArtifacts.sarif" />
- <EmbeddedResource Include="TestData\GitHubIngestionVisitor\ExpectedOutputs\WithInvocation.sarif" />
  <EmbeddedResource Include="TestData\GitHubIngestionVisitor\ExpectedOutputs\TooManyResults.sarif" />
  <EmbeddedResource Include="TestData\GitHubIngestionVisitor\Inputs\NonErrorResults.sarif" />
  <EmbeddedResource Include="TestData\GitHubIngestionVisitor\Inputs\Fingerprints.sarif" />
  <EmbeddedResource Include="TestData\GitHubIngestionVisitor\Inputs\ThreadFlowLocations.sarif" />
  <EmbeddedResource Include="TestData\GitHubIngestionVisitor\Inputs\WithArtifacts.sarif" />
- <EmbeddedResource Include="TestData\GitHubIngestionVisitor\Inputs\WithInvocation.sarif" />
  <EmbeddedResource Include="TestData\GitHubIngestionVisitor\Inputs\TooManyResults.sarif" />
  <EmbeddedResource Include="TestData\InsertOptionalDataVisitor\ExpectedOutputs\CoreTests-Relative_VersionControlInformation.sarif" />
  <EmbeddedResource Include="TestData\Readers\elfie-arriba-utf8-bom.sarif" />

diff --git a/...Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/ExpectedOutputs/WithInvocation.sarif b/...Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/ExpectedOutputs/WithInvocation.sarif
diff --git a/src/Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/Inputs/WithInvocation.sarif b/src/Test.UnitTests.Sarif/TestData/GitHubIngestionVisitor/Inputs/WithInvocation.sarif
diff --git a/src/Test.UnitTests.Sarif/Visitors/GitHubIngestionVisitorTests.cs b/src/Test.UnitTests.Sarif/Visitors/GitHubIngestionVisitorTests.cs
@@ -42,10 +42,6 @@ public void GitHubDspIngestionVisitor_LimitsNumberOfResults()
  }
  }
 
- [Fact]
- public void GitHubDspIngestionVisitor_RemovesInvocations()
- => RunTest("WithInvocation.sarif");
-
  [Fact]
  public void GitHubDspIngestionVisitor_RemovesArtifactsAndRetainsIndirectArtifactLocations()
  => RunTest("WithArtifacts.sarif");