Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing null reference when using VersionControlInformation #2222

Merged
merged 4 commits into from
Jan 6, 2021

Conversation

eddynaka
Copy link
Collaborator

@eddynaka eddynaka commented Jan 6, 2021

No description provided.

Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -40,6 +41,7 @@ public InsertOptionalDataVisitor(OptionallyEmittedData dataToInsert, Run run)
_dataToInsert = dataToInsert;
_originalUriBaseIds = originalUriBaseIds;
_ruleIndex = -1;
_gitHelper = new GitHelper();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHelper [](start = 29, length = 9)

Let's change the insert data option name that was broken to VersionControlDetails (from VersionControlInformation)

@eddynaka eddynaka enabled auto-merge (squash) January 6, 2021 19:54
@eddynaka eddynaka disabled auto-merge January 6, 2021 19:56
@eddynaka eddynaka merged commit 019fd07 into main Jan 6, 2021
@eddynaka eddynaka deleted the users/ednakamu/fixing-null-reference branch January 6, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants