Fix location Uri and number of artifact in work item description #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 713df2d into b262841 - view on LGTM.com new alerts:
|
|
This is for #2385 |
eddynaka
reviewed
Oct 5, 2021
| } | ||
|
|
||
| [Fact] | ||
| public void SarifWorkItemExtensions_CreateWorkItemDescription_SingleResultWithMultipleArtifacts() |
eddynaka
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2385
Existing code calculate total artifacts using global artifacts, which includes all artifacts if referenced by result's codeFlows/relatedLocations, and pick first artifact uri in description, which may not be the result's location uri.
The change is only calculate artifacts based on results.