Threading fixes #2618
Merged
Threading fixes #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcfanning
requested review from
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
shaopeng-gh
reviewed
Feb 15, 2023
| @@ -11,6 +11,8 @@ | |||
| * BRK: For `Guid` properties defined in SARIF spec, updated Json schema to use `uuid`, and updated C# object model to use `Guid?` instead of `string`. [#2555](https://github.com/microsoft/sarif-sdk/pull/2555) | |||
| * BRK: Mark `AnalyzeCommandBase` as obsolete. This type will be removed in the next significant update. [#2599](https://github.com/microsoft/sarif-sdk/pull/2599) | |||
| * BRK: `LogUnhandledEngineException` no longer has a return value (and updates the `RuntimeErrors` context property directly as other helpers do). [#2599](https://github.com/microsoft/sarif-sdk/pull/2599) | |||
| * BUG: Populate missing context region data for small, single-line scan targets. [#2616](https://github.com/microsoft/sarif-sdk/pull/2616) | |||
| * BUG: Increase parallelism in `MultithreadedAnalyzeCommandBase` by correcting task creation. []#2618](https://github.com/microsoft/sarif-sdk/pull/2618) | |||
suvamM
reviewed
Feb 15, 2023
|
|
||
| // 2: Files found on disk are put in a specific sort order, after which a | ||
| // reference to each scan target is put into a channel for hashing, | ||
| // if hashing is enabled. | ||
| Task<bool> hashFilesAndPutInAnalysisQueue = HashFilesAndPutInAnalysisQueueAsnc(); | ||
| Task<bool> hashFilesAndPutInAnalysisQueue = Task.Run(() => HashFilesAndPutInAnalysisQueueAsnc()); |
suvamM
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
@michaelcfanning This looks good to me. But I had a question about the procedure: this an open PR. There is already a release for sarif-pattern-matcher which references a commit in this PR. Ideally, we should have dependencies from the main branch of sarif-sdk and not dev branches.
|
We don't currently sim-ship the SDK when we ship the scanner. This is because the scanner is intended to be a client tool that consumes the OSS source as source, i.e., via submodule. We don't take a NuGet package dependency and so there isn't pressure to keep the NuGet delivery in sync with sarif pattern matcher. Open to your thoughts on this topic. In reply to: 1299909340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ouch. We previously created all tasks on a common thread. We have a mile-wide bug in our unit-testing which we need to close.
@shaopeng-gh