Fix GetBlame: Fixes #2683 #2684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvremelM
requested review from
michaelcfanning,
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
AvremelM
commented
Jun 15, 2023
|
@AvremelM, I have merged this useful fix into a larger PR that I'm about to open, will loop you into that. |
|
Assuming you refer to #2686, it looks like you may have included only the first line of my change, not the second, which removes the call to |
|
Thanks for the fix! I've added you as a write contributor. In future, if you have more good stuff for the project, you can branch directly off main and submit your PRs. |
|
@michaelcfanning Thank you! And thanks for inviting me! I'll close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for inserting git blame information.
Fixes #2683