Enable core function for archive enumeration/scanning. #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
reviewed
Oct 29, 2024
src/Sarif/ArtifactProvider.cs
Outdated
|
|
||
| if (ExtensionsAllowList != null) | ||
| { | ||
| return !ExtensionsAllowList.Contains(extension); |
There was a problem hiding this comment.
It's surprising to me that the deny list is ignored if there is an allow list.
If users are required to use one or the other but not both, then perhaps we should check that they don't try to use both.
nguerrera
reviewed
Oct 29, 2024
src/Sarif/HashData.cs
Outdated
| @@ -1,3 +1,4 @@ | |||
|
|
|||
| // Copyright (c) Microsoft. All rights reserved. | |||
nguerrera
reviewed
Oct 29, 2024
src/Sarif/SarifExtensionMethods.cs
Outdated
| @@ -253,12 +253,20 @@ public static string GetFileName(this Uri uri) | |||
| return newAbsoluteUri.AbsolutePath.Split('/').Last(); | |||
| } | |||
|
|
|||
| if (uri.Query != null) | |||
| { | |||
| return uri.Query; | |||
There was a problem hiding this comment.
Why would the query information be considered the file name?
nguerrera
reviewed
Oct 29, 2024
src/Sarif/ZipArchiveArtifact.cs
Outdated
| } | ||
|
|
||
| this.uri = baseUri != null | ||
| ? new Uri($"{baseUri}?{entry.FullName}") |
nguerrera
reviewed
Oct 29, 2024
| { | ||
| return entry.Open(); | ||
| } | ||
| catch (InvalidDataException) |
nguerrera
reviewed
Oct 29, 2024
| } | ||
| catch(InvalidDataException) | ||
| { | ||
| // TBD log corrupt zip file. |
|
I just saw that this is a draft. Silly GitHub sent me email about it. Sorry if you weren't ready for feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.