Make the build compatible with .NET 9 SDK #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nguerrera
commented
Nov 18, 2024
•
nguerrera
commented
- Move all warning-as-error handling to build props
- Disable warning-as-error in Debug builds
- Lower AnalysisLevel to .NET 8 wave when treating warnings as errors in Release
- Pass --self-contained explicitly to dotnet publish with runtime identifier for forward compat
nguerrera
requested review from
michaelcfanning,
suvamM,
shaopeng-gh,
rwoll,
yongyan-gh,
LingZhou-gh,
EasyRhinoMSFT and
cfaucon
as code owners
nguerrera
commented
Nov 18, 2024
| @@ -2,7 +2,10 @@ | |||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
|
|
|||
| <PropertyGroup> | |||
| <LangVersion>8.0</LangVersion> | |||
There was a problem hiding this comment.
Note that this was already reset to latest below this before.
nguerrera
commented
Nov 18, 2024
| @@ -38,7 +38,7 @@ $npmBuildFolder = "$BuildRoot\Publish\npm" | |||
| if (-not $SkipBuild) { | |||
| Write-Information "Building Sarif.Multitool for Windows, Linux, and MacOS..." | |||
| foreach ($runtime in "win-x64", "linux-x64", "osx-x64") { | |||
| dotnet publish $SourceRoot\$project\$project.csproj -c $Configuration -f netcoreapp3.1 -r $runtime | |||
| dotnet publish $SourceRoot\$project\$project.csproj -c $Configuration -f netcoreapp3.1 -r $runtime --self-contained | |||
There was a problem hiding this comment.
This fixes a .NET 9 SDK warning that tells us that --self-contained will no longer be the default as before when runtime identifier is specified.
* Move all warning-as-error handling to build props * Disable warning-as-error in Debug builds * Lower AnalysisLevel to .NET 8 wave when treating warnings as errors in Release * Pass --self-contained explicitly to dotnet publish with runtime identifier for forward compat
nguerrera
force-pushed
the
net9-sdk-compat
branch
from
1eaaed1 to
973dc49
Compare
nguerrera
commented
Nov 18, 2024
| @@ -0,0 +1,3 @@ | |||
| <Project> | |||
| <Import Project="build.warnings_as_errors.props" /> | |||
There was a problem hiding this comment.
It is maddeningly difficult to get the same behavior for building .sln as .csproj for these settings.
joscol
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.