Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File rooting bugfixes + VS 19 json fixes #606

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

edkazcarlson-ms
Copy link
Collaborator

This PR addresses 2 main bugfixes:

  1. The extension does not play well in VS 19 after I tried to upgrade the ver of the json nuget. Here is a blogpost about it but in short every ver of VS ships with its own ver of the newtonsoft json nuget, but when you use a ver that is outside the one that it is shipped with, it can cause issues. In this case, vs 19 comes w/ newtonsoft 12 and so it didn't like how I increased the ver to 13.
  2. When opening files through the drag and drop or through the File > Open > File and you don't have the appropriate folder/solution open, it will fail to link the relative file path in the sarif object to the absolute file path on disk if they file seperators are different (/ vs )

@EasyRhinoMSFT
Copy link
Collaborator

EasyRhinoMSFT commented Oct 5, 2023

Shoot, I forgot to block on the Newtonsoft thing, sorry. #Resolved

Copy link
Collaborator

@EasyRhinoMSFT EasyRhinoMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edkazcarlson-ms edkazcarlson-ms merged commit 2a38c61 into feature/devcanvas Oct 5, 2023
3 checks passed
@edkazcarlson-ms edkazcarlson-ms deleted the user/ecarlson/fix-19-new-102 branch October 5, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants