Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SBOM Tool Main Build to 1ESPT #535

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Convert SBOM Tool Main Build to 1ESPT #535

merged 6 commits into from
Apr 2, 2024

Conversation

sfoslund
Copy link
Member

@sfoslund sfoslund commented Apr 1, 2024

@sfoslund sfoslund requested a review from a team as a code owner April 1, 2024 21:57
@pownkel
Copy link
Contributor

pownkel commented Apr 2, 2024

I noticed that the structure of the published build artifacts is different between the two pipelines - the original puts all binaries in SBOMTool/bin, but the new YAML Pipeline separates the outputs into different directories by platform. Do we expect this to work with our current release pipeline, or will changes also be needed there?

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (4915b72) to head (764263a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files         248      248           
  Lines        7572     7572           
  Branches      900      900           
=======================================
  Hits         4523     4523           
  Misses       2637     2637           
  Partials      412      412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfoslund
Copy link
Member Author

sfoslund commented Apr 2, 2024

I noticed that the structure of the published build artifacts is different between the two pipelines - the original puts all binaries in SBOMTool/bin, but the new YAML Pipeline separates the outputs into different directories by platform. Do we expect this to work with our current release pipeline, or will changes also be needed there?

Because of the way 1ESPT publishes artifacts we won't be able to publish all of the artifacts from all of the jobs to the same directory (see this failed run as an example). But we will need to update the release pipeline anyways with the following changes:

  • Point to the new yaml pipeline instead of the old classic one (which I will be deleting once this PR is merged)
  • Account for new placement of SBOM in artifact dir structure
  • Account for new placement of linux/ mac artifacts in new artifact dir structure

@sfoslund sfoslund merged commit 85cb4ed into main Apr 2, 2024
7 checks passed
@sfoslund sfoslund deleted the sfoslund/pt branch April 2, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants