chore: Output failure telemetry if signing validation fails #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As called out in #501, telemetry is reporting success even if the manifest signing check fails. This PR fixes this via the following additions:
validFailures
. This will be used in thefinally
block to capture the telemetry resultsLogResultsSummary
andLogIndividualFileResults
so that we don't generate unhelpful log output after signing validation failsTested locally by forcing the signing failure in the debugger and observing the rest of the execution. The resulting telemetry log reports the error as follows:
I left the
Path
field blank, since it wasn't available in the scope of this function and since it can be inferred from theParameters
object that exists in the raw file but that I omitted for brevity.