Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate-format verb with placeholder for future validation #577

Merged
merged 2 commits into from
May 20, 2024

Conversation

alisonlomaka
Copy link
Member

Wire up a validate-format verb that runs the format validation logic for a specified file. This is a hidden verb that I imagine being used during development, and in future by DRI to explore an SBOM or troubleshoot a validation failure. This change is just the boilerplate required to add and call the new verb; actual validation logic will be in the next PR.

…for a specified file. This is a hidden verb that I imagine being used during development, and in future by DRI to explore an SBOM or troubleshoot a validation failure.
@alisonlomaka alisonlomaka requested a review from a team as a code owner May 20, 2024 20:01
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 58.81%. Comparing base (29bc8fb) to head (71df3a5).

Files Patch % Lines
.../Microsoft.Sbom.Api/Config/ConfigurationBuilder.cs 0.00% 3 Missing ⚠️
src/Microsoft.Sbom.Api/Config/SbomToolCmdRunner.cs 0.00% 3 Missing ⚠️
...osoft.Sbom.Api/Config/Args/FormatValidationArgs.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   58.67%   58.81%   +0.14%     
==========================================
  Files         253      254       +1     
  Lines        7852     7894      +42     
  Branches      920      922       +2     
==========================================
+ Hits         4607     4643      +36     
- Misses       2828     2834       +6     
  Partials      417      417              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alisonlomaka alisonlomaka merged commit 1d832e0 into main May 20, 2024
6 checks passed
@alisonlomaka alisonlomaka deleted the alisonl/validateFormat branch May 20, 2024 20:46
tarun06 pushed a commit to tarun06/sbom-tool that referenced this pull request Jul 21, 2024
…osoft#577)

* Wire up a validate-format verb that runs the format validation logic for a specified file. This is a hidden verb that I imagine being used during development, and in future by DRI to explore an SBOM or troubleshoot a validation failure.

* Fix PR comment - removing duplicated parameter validation code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants