Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix JSON002 error #603

Merged
merged 2 commits into from
Jul 2, 2024
Merged

chore: Fix JSON002 error #603

merged 2 commits into from
Jul 2, 2024

Conversation

DaveTryon
Copy link
Contributor

Building the project locally, I get 2 errors when I happen to have this file opened in the IDE:

Severity Code Description Project File Line
Error (active) JSON002 Probable JSON string detected Microsoft.Sbom.Api.Tests (net6.0), Microsoft.Sbom.Api.Tests (net8.0) .\test\Microsoft.Sbom.Api.Tests\Config\ConfigurationBuilderTestsBase.cs 65
Error (active) JSON002 Probable JSON string detected Microsoft.Sbom.Api.Tests (net6.0), Microsoft.Sbom.Api.Tests (net8.0) .\test\Microsoft.Sbom.Api.Tests\Config\ConfigurationBuilderTestsBase.cs 66

The IDE suggests making these interpolated strings, which silences the error. Seems like the IDE is being a bit extra picky, but the low-risk change seems like a better option than adding some sort of override.

@DaveTryon DaveTryon requested a review from a team as a code owner July 1, 2024 23:55
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.82%. Comparing base (494fa75) to head (47538dd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   59.82%   59.82%           
=======================================
  Files         268      268           
  Lines        8249     8249           
  Branches      972      972           
=======================================
  Hits         4935     4935           
  Misses       2886     2886           
  Partials      428      428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaveTryon DaveTryon merged commit cdc046a into main Jul 2, 2024
6 checks passed
@DaveTryon DaveTryon deleted the dtryon/fix-json002-error branch July 2, 2024 18:53
tarun06 pushed a commit to tarun06/sbom-tool that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants