More cleanup sparse (#1368)

* Normalize paths that are saved in the sparse table

* Add comment for how the IsRecursive for a sparse folder is set

* Add verification for mockCommand3 in GVFSDatabaseTests

* Rename sparse test

* Add some validation to sparse folder test

* Rename method that validate folders to ValidateFoldersInSparseList

* Add to and update the sparse tests

* Add tests for various paths for the sparse verb and trim spaces

GVFS/GVFS.Common/Database/SparseTable.cs

@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Data;
 using System.IO;
-using System.Text;
 
 namespace GVFS.Common.Database
 {
@@ -15,6 +14,11 @@ public SparseTable(IGVFSConnectionPool connectionPool)
             this.connectionPool = connectionPool;
         }
 
+        public static string NormalizePath(string path)
+        {
+            return path.Replace(Path.AltDirectorySeparatorChar, Path.DirectorySeparatorChar).Trim().Trim(Path.DirectorySeparatorChar);
+        }
+
         public static void CreateTable(IDbConnection connection)
         {
             using (IDbCommand command = connection.CreateCommand())
@@ -24,21 +28,21 @@ public static void CreateTable(IDbConnection connection)
             }
         }
 
-        public void Add(string directory)
+        public void Add(string directoryPath)
         {
             try
             {
                 using (IDbConnection connection = this.connectionPool.GetConnection())
                 using (IDbCommand command = connection.CreateCommand())
                 {
                     command.CommandText = "INSERT OR REPLACE INTO Sparse (path) VALUES (@path);";
-                    command.AddParameter("@path", DbType.String, directory);
+                    command.AddParameter("@path", DbType.String, NormalizePath(directoryPath));
                     command.ExecuteNonQuery();
                 }
             }
             catch (Exception ex)
             {
-                throw new GVFSDatabaseException($"{nameof(SparseTable)}.{nameof(this.Add)}({directory}) Exception: {ex.ToString()}", ex);
+                throw new GVFSDatabaseException($"{nameof(SparseTable)}.{nameof(this.Add)}({directoryPath}) Exception: {ex.ToString()}", ex);
             }
         }
 
@@ -68,21 +72,21 @@ public HashSet<string> GetAll()
             }
         }
 
-        public void Remove(string directory)
+        public void Remove(string directoryPath)
         {
             try
             {
                 using (IDbConnection connection = this.connectionPool.GetConnection())
                 using (IDbCommand command = connection.CreateCommand())
                 {
                     command.CommandText = "DELETE FROM Sparse WHERE path = @path;";
-                    command.AddParameter("@path", DbType.String, directory);
+                    command.AddParameter("@path", DbType.String, NormalizePath(directoryPath));
                     command.ExecuteNonQuery();
                 }
             }
             catch (Exception ex)
             {
-                throw new GVFSDatabaseException($"{nameof(SparseTable)}.{nameof(this.Remove)}({directory}) Exception: {ex.ToString()}", ex);
+                throw new GVFSDatabaseException($"{nameof(SparseTable)}.{nameof(this.Remove)}({directoryPath}) Exception: {ex.ToString()}", ex);
             }
         }
     }