Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RemoveVerb a subset of ReposVerb #274

Closed
derrickstolee opened this issue Jan 2, 2020 · 0 comments · Fixed by #292
Closed

Make RemoveVerb a subset of ReposVerb #274

derrickstolee opened this issue Jan 2, 2020 · 0 comments · Fixed by #292
Assignees
@derrickstolee

Comments

@derrickstolee
Copy link
Contributor

from John:

Having scalar repos right next to scalar remove makes me concerned about confusion between the commands. In the future, should we have scalar repos remove take on the functionality of scalar remove? or scalar repos remove --from-disk while scalar repos remove just de-registers? Just something to think about.

As part of the planned scalar repos remove [<dir>] option (which de-registers the repo from the service), also add the --from-disk option.
@derrickstolee derrickstolee self-assigned this Jan 2, 2020
This was referenced Jan 2, 2020
Merged
Closed
@derrickstolee derrickstolee mentioned this issue Jan 10, 2020
Merged
derrickstolee added a commit that referenced this issue Jan 14, 2020
@derrickstolee
Merge pull request #292: Rework the command-line interface
ca1b26a 
This PR is probably too large and I'll need to split it into smaller parts. However, it has the full story of how to redo our command-line interface:

* Commands `clone`, `diagnose`, `config`, `cache-server` are untouched.

* The `repos` command is dropped in favor of `register`, `list`, and `unregister`. Resolves #286.

* Created the `pause` and `resume` commands. Starts #284.

* Replaced `remove` with `delete`. Resolves #274.

* Reorganized the `docs` folder. Instead of a command reference page for each command, commands are grouped by purpose and documented together. These sections are:

  - **Getting Started:** `clone`, `register`, `unregister`, `delete`.
  - **Advanced:** `run`, `pause`, `resume`.
  - **Troubleshooting:** `upgrade`, `diagnose`, `config`, `cache-server`.

Not done yet, but can be done in a later PR:

* Update the `README.md` with new information and point to the docs.

* `scalar run all` to run all maintenance tasks on an enlistment. (See #287)
@derrickstolee derrickstolee mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derrickstolee derrickstolee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework the command-line interface
ReposVerb: add 'remove' subcommand
1 participant
@derrickstolee