Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PR validation pipeline #3

Closed
jrbriggs opened this issue Aug 7, 2019 · 4 comments
Closed

Create PR validation pipeline #3

jrbriggs opened this issue Aug 7, 2019 · 4 comments
Assignees
@derrickstolee
Labels
engineering
Milestone
Demo

Comments

@jrbriggs
Copy link
Member

jrbriggs commented Aug 7, 2019

Must have:
macOS build + unit tests
Windows build + unit tests
@jrbriggs jrbriggs mentioned this issue Aug 8, 2019
Closed
@derrickstolee derrickstolee self-assigned this Aug 8, 2019
@derrickstolee
Copy link
Contributor

I see we already have some YAML. We just need Pipelines connections to the repo. Investigating.

@derrickstolee
Copy link
Contributor

Hm... I ran into issues and will reopen this for others.

  1. this repo is private, so our gvfs/ci project can't connect to it.

  2. When I tried to connect via mseng, I got the following error: Service connection with name microsoft already exists. Only a user having Administrator/User role permissions on service connection microsoft can see it.

@derrickstolee derrickstolee removed their assignment Aug 8, 2019
@derrickstolee derrickstolee added this to the Demo milestone Aug 8, 2019
@derrickstolee
Copy link
Contributor

@jrbriggs could we create a new (private) project in https://dev.azure.com/gvfs to connect to this repo? One of us is an admin there, so should be able to manage the connection.

@derrickstolee derrickstolee mentioned this issue Aug 8, 2019
Merged
@derrickstolee derrickstolee self-assigned this Aug 8, 2019
derrickstolee added a commit that referenced this issue Aug 8, 2019
@derrickstolee
Merge pull request #16: Update pull-request.yml for Azure Pipelines
40bc492 
Makes progress towards #3 by fixing the Windows build and having it run as a PR check via YAML.
@derrickstolee
Copy link
Contributor

This is good to go for now, as of #32. We can add more tests later, but we have a good start now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derrickstolee derrickstolee

Labels
engineering
Projects
None yet
Milestone
Demo
Development

No branches or pull requests
2 participants
@derrickstolee @jrbriggs