Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git: core.gvfs config setting #64

Closed
derrickstolee opened this issue Aug 16, 2019 · 3 comments · Fixed by #106
Closed

Git: core.gvfs config setting #64

derrickstolee opened this issue Aug 16, 2019 · 3 comments · Fixed by #106
Assignees
Milestone

Comments

@derrickstolee
Copy link
Contributor

The core.gvfs config setting does a lot of things, including block unwanted commands.

This setting was dropped as part of the rename effort (#38) and should be put back for now.

However, there are a lot of things that config options does that we may not want it to do in the Scalar world. Update Git to split those actions apart based on other config options or add a core.scalar for our situation.

For example, we still want to block git gc, but that could be part of core.virtualizeobjects instead.

@derrickstolee derrickstolee added this to the MVP milestone Aug 16, 2019
@wilbaker wilbaker self-assigned this Aug 16, 2019
derrickstolee added a commit that referenced this issue Aug 16, 2019
This was fallout from #38.

See #64 for more discussion on the future of this setting.
@github-actions
Copy link

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Aug 17, 2019
@jrbriggs jrbriggs removed the no-activity Stale issue or PR that will be automatically closed soon. label Aug 17, 2019
@github-actions
Copy link

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

@github-actions github-actions bot added the no-activity Stale issue or PR that will be automatically closed soon. label Aug 19, 2019
@wilbaker wilbaker removed the no-activity Stale issue or PR that will be automatically closed soon. label Aug 19, 2019
@derrickstolee derrickstolee modified the milestones: MVP, EA Aug 21, 2019
@derrickstolee
Copy link
Contributor Author

I'm moving this issue to the EA milestone after talking with @wilbaker about it.

This is likely a blocker for merging the sparse-checkout feature branch into vfs-2.2x.0 since we likely do not want VFS for Git repos to run git sparse-checkout. Further, we may want things like the transport layer (#7, #36) to be a "scalar only" feature.

However, I don't see anything here blocking us from collecting the performance data we need for MVP. In fact, we likely won't want to merge the sparse-checkout feature branch into vfs-2.2x.0 until we have completed our performance investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants