Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused verbs: log and repair #182

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Delete unused verbs: log and repair #182

merged 1 commit into from
Oct 18, 2019

Conversation

derrickstolee
Copy link
Contributor

@derrickstolee derrickstolee commented Oct 18, 2019 •
edited
Loading

LogVerb: this verb just isn't useful. We are going to change the log
behavior anyway.

RepairVerb: VFS for Git used to modify the index and HEAD in a way that
could lead to corruption. The repair verb was necessary to fix users
that hit those bugs. We should not need repairs in Scalar.

@derrickstolee derrickstolee added this to the MVP milestone Oct 18, 2019
@derrickstolee derrickstolee marked this pull request as ready for review October 18, 2019 13:26
jrbriggs
jrbriggs suggested changes Oct 18, 2019
View reviewed changes
Copy link
Member

@jrbriggs jrbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we delete the config verb, where do we anticipate storing the upgrade feed config?

@derrickstolee derrickstolee changed the title Delete unused verbs: config, log, repair Delete unused verbs: log and repair Oct 18, 2019
wilbaker
wilbaker approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@wilbaker wilbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a small suggestion

Scalar/Scalar.Windows.csproj Show resolved Hide resolved
@derrickstolee
Delete unused verbs: log and repair
c9795fe 
LogVerb: this verb just isn't useful. We are going to change the log
behavior anyway.

RepairVerb: VFS for Git used to modify the index and HEAD in a way that
could lead to corruption. The repair verb was necessary to fix users
that hit those bugs. We should not need repairs in Scalar.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee derrickstolee merged commit 65591ea into microsoft:master Oct 18, 2019
@derrickstolee derrickstolee deleted the delete-verbs branch November 18, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbriggs jrbriggs jrbriggs approved these changes

@wilbaker wilbaker wilbaker approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.
3 participants
@derrickstolee @jrbriggs @wilbaker