Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LooseObjectsStep: simplify code for getting directory paths #218

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

wilbaker
Copy link
Member

@wilbaker wilbaker commented Nov 6, 2019

The code in CountLooseObjects can be simplified by avoiding
an unnecessary Path.Combine.

Additionally, fix a bug in the MockFileSystem where EnumerateDirectories
was not returning the full paths of directories and it should.

I found this while updating the unit tests as part of #216, the port to VFS4G is here: microsoft/VFSForGit#1570

@wilbaker wilbaker added the bug correctness issues label Nov 6, 2019
Scalar.Common/Maintenance/LooseObjectsStep.cs Outdated Show resolved Hide resolved
@wilbaker wilbaker force-pushed the fix_count_loose_objects branch from e97ec7b to ebb4b0b Compare November 6, 2019 18:20
@wilbaker wilbaker removed the bug correctness issues label Nov 6, 2019
@wilbaker wilbaker changed the title LooseObjectsStep: fix CountLooseObjects LooseObjectsStep: simply code for getting directory names and paths Nov 6, 2019
The code in CountLooseObjects can be simplified by avoiding
an unnecessary Path.Combine.

Additionally, fix a bug in the MockFileSystem where EnumerateDirectories
was not returning the full paths of directories and it should.
@wilbaker wilbaker force-pushed the fix_count_loose_objects branch from ebb4b0b to f3ecc5f Compare November 6, 2019 19:02
@wilbaker wilbaker changed the title LooseObjectsStep: simply code for getting directory names and paths LooseObjectsStep: simply code for getting directory paths Nov 6, 2019
@wilbaker
Copy link
Member Author

wilbaker commented Nov 6, 2019

Waiting a day on #201 before merging.

@derrickstolee derrickstolee changed the title LooseObjectsStep: simply code for getting directory paths LooseObjectsStep: simplify code for getting directory paths Nov 6, 2019
@wilbaker wilbaker merged commit 9f7c8bb into microsoft:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants