Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecureDataRoot directory for secure files #265

Merged
merged 5 commits into from
Dec 19, 2019
Merged

SecureDataRoot directory for secure files #265

merged 5 commits into from
Dec 19, 2019

Conversation

alameenshah
Copy link
Contributor

@alameenshah alameenshah commented Dec 19, 2019 •
edited
Loading

Changes in ScalarPlatform

  • Renamed GetDataRootForScalar() to GetCommonAppDataRootForScalar()
  • Created new method GetSecureDataRootForScalar()
  • Created new convenience method GetLogsDirectoryForGVFSComponent() to get a component's log directory.

What is stored in the Secure Data Root

  • scalar config file
  • (In future) Upgrader tool and artifacts that it downloads.

Other updates

  • Scalar verbs, Service & ServiceUI use the new apis.
  • Diagnose verb copies both SecureDataRoot\Service> and CommonAppDataRoot\<Service> directories.
  • Functional Tests use the new SecureDataRoot.

@alameenshah
SecureDataRoot directory for secure files (1)
469a43c 
- Renamed DataRoot to CommonAppDataRoot
- Created new platform method SecureDataRoot
- Created new conveniance method in platform to get a
  component's log directory.
@alameenshah
SecureDataRoot directory for secure files (2)
3548cfb 
- Keep scalar config file in secure data root
@alameenshah
SecureDataRoot directory for secure files (3)
d7570bb 
- Updated scalar verbs to use the new CommonAppDataRoot
  (or SecureDataRoot) apis.
- Updated Service & ServiceUI.
@alameenshah
SecureDataRoot directory for secure files (4)
4e184e3 
- Updated Diagnose verb to copy both SecureData and AppData roots.
- Updated scalar config file path in Diagnose verb
- Updated Functional Tests to use the new SecureDataRoot.
@alameenshah alameenshah self-assigned this Dec 19, 2019
@derrickstolee
Copy link
Contributor

@alameenshah: just to confirm, we are not setting any ACLs on the path from GetSecureDataRootForScalar(), right? We are only setting ACLs on the GetCommonAppDataRootForScalar()?

Should we remove all ACL-adjusting code for these paths?

@alameenshah
SecureDataRoot directory for secure files (5)
02e76f5 
- Don't set custom ACLs on SecureDataRoot directory
@alameenshah alameenshah merged commit 3eb4282 into microsoft:master Dec 19, 2019
@derrickstolee derrickstolee mentioned this pull request Jan 6, 2020
Closed
@jrbriggs jrbriggs mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickstolee derrickstolee derrickstolee approved these changes

@jrbriggs jrbriggs Awaiting requested review from jrbriggs

@kewillford kewillford Awaiting requested review from kewillford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alameenshah @derrickstolee