Remove dead GVFSLock and GitStatusCache code #29
Conversation
There was a problem hiding this comment.
Maybe @jamill can chime in here, but the background status cache will not work at first for sure. We will see about enabling it later, but it may require a significant redesign and hence it makes sense to delete now.
@derrickstolee @jamill yeah I was a bit on the fence with the status cache. In its current form it's refreshes are driven by events we don't have from the virtualization layer, and it answers requests from the pre-command hook which we don't have either. My thought was that it would be easier to surgically lift whatever we end up wanting/needing from VFS4G at a later time than leaving the current code in place here. My original plan was to leave the current code in, but it is so tightly coupled to the lock and virtualization code there was not much left after I remove those portions. |
|
Ship it! I completely agree with your assessment. |
In PR microsoft#29 and commit cedeeaa the VFSForGit GitStatusCache implementation was removed from Scalar. However, the functional test suite still checked for and created the EnableGitStatusCacheToken.dat file if it was missing (but only on Windows). Since this setup is no longer relevant, we can remove it now.
In PR microsoft#29 and commit cedeeaa the VFSForGit GitStatusCache implementation was removed from Scalar. However, the functional test suite still checked for and created the EnableGitStatusCacheToken.dat file if it was missing (but only on Windows). Since this setup is no longer relevant, we can remove it now.
The last caller of the IsProcessActive() methods in the ScalarPlatform classes were removed in commit cedeeaa in PR microsoft#29. Therefore we can remove this method as well as the native Windows ProcessActiveFlags and several Win32 system call wrappers.
The last caller of the IsProcessActive() methods in the ScalarPlatform classes was removed in commit cedeeaa in PR microsoft#29. Therefore we can remove this method as well as the native Windows system call wrappers and enums which were used only by the WindowPlatform implementation of this method.
The last caller of the IsProcessActive() methods in the ScalarPlatform classes was removed in commit cedeeaa in PR microsoft#29. Therefore we can remove this method as well as the native Windows system call wrappers and enums which were used only by the WindowPlatform implementation of this method.
This code is not needed for GSD