Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FetchStep: use '--prune' and refs/scalar/hidden #298

Merged
merged 4 commits into from
Jan 20, 2020
Merged

FetchStep: use '--prune' and refs/scalar/hidden #298

merged 4 commits into from
Jan 20, 2020

Conversation

derrickstolee
Copy link
Contributor

Resolves #289.

  1. When using our custom refspec, --prune does not delete remote refs, but will delete our custom refs. So, use it! Delete our custom code for deleting the hidden refs directory.

  2. Make the refspec use ScalarConstants a bit better, and update the refs to update refs/scalar/hidden instead of refs/hidden.

Copy link
Member

@kewillford kewillford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Scalar.Common/Git/GitProcess.cs Show resolved Hide resolved
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Copy link
Member

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; a few minor questions and comments.

Signed-off-by: Derrick Stolee <stolee@gmail.com>
Signed-off-by: Derrick Stolee <stolee@gmail.com>
@microsoft microsoft deleted a comment from azure-pipelines bot Jan 20, 2020
@microsoft microsoft deleted a comment from azure-pipelines bot Jan 20, 2020
@derrickstolee derrickstolee merged commit 3dfab39 into microsoft:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background fetch: follow-up details
3 participants