ConfigStep: disable status.submoduleSummary when using GVFS protocol #383
Conversation
A VFS for Git user noticed extremely slow "git status" times, and the root cause was that they had set status.submoduleSummary=true in their global config. This causes two "git submodule" subprocesses, which are very slow. The GVFS protocol does not allow submodules, so disable the setting when using that protocol. I investigating fixing this in Git proper, but there is no efficient way to detect that we can ignore this setting since there could be an untracked submodule. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
|
are we setting this as a "git config --global ..." value? not trying to redesign gvfs, but would it be better to set this (and the ahead/behind value) as a repo-local config setting when the repo is cloned, so that Git behaves as expected on normal repos?? |
|
i'm not criticizing the choice here, just I can't follow the large picture from the context available here. |
We are setting it locally to the repo. The experience before this is that a user has it set globally, so it applies locally. We are just trying to disable it locally, overriding their (possibly present) global value. |
|
ok. i think i mis-read the comment. we're setting it false locally to override any global setting that they may have. |
A VFS for Git user noticed extremely slow "git status" times, and the
root cause was that they had set status.submoduleSummary=true in their
global config. This causes two "git submodule" subprocesses, which are
very slow. The GVFS protocol does not allow submodules, so disable the
setting when using that protocol.
I investigating fixing this in Git proper, but there is no efficient
way to detect that we can ignore this setting since there could be
an untracked submodule.