CheckGitVersion: improve error messages #403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported issues with parsing our Git version when cloning. Our
best guess of what happened is that the build machine already had a
version of Git, but it was in a different location whan where our
brew
formula placed our version of Git. This led the parser to not see a
.vfs.
in the version string and fail.Let's make this error more informative. While we are here, split the
failure condition into two distinct cases:
Signed-off-by: Derrick Stolee dstolee@microsoft.com