FunctionalTests: drop unused negative runner methods #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can prune the various negative "should fail" and "should not" methods from the FileSystemRunner classes as these are no longer utilized by any tests. These methods were previously used by the BasicFileSystemTests and MoveRenameFolderTests, which were removed in commit d748084.
chrisd8088
force-pushed
the
prune-unused-code
branch
from
46598af
to
a435930
Compare
derrickstolee
approved these changes
Oct 5, 2020
mjcheetham
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can prune the various negative "should fail" and "should not" methods from the
FileSystemRunnerclasses as these are no longer utilized by any tests.These methods were previously used by the
BasicFileSystemTestsandMoveRenameFolderTests, which were removed in commit d748084.Three additional methods could also be removed from these runner classes, namely
FileSize(),ReplaceFile(), andRenameDirectory(). I left them in because it seemed like they might be more obviously useful in the future than the "negative" methods.OTOH these three additional unused methods could also be pruned now and then resurrected from Git history if they are ever needed again. If the latter is preferred, I can add commit d32582c to this PR to also drop them; just let me know either way.