Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on LF thoughout the repository. #46

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

jrbriggs
Copy link
Member

@jrbriggs jrbriggs commented Aug 13, 2019

Note to reviewers: if you disable whitespace diff, you'll still see most files have a diff on the first line. On spot checking a few, this is the removal of the BOM.

Copy link
Member

@nickgra nickgra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot checked a few files (.cs, .h, .bat) and they all look good.

Curiously enough, we have issues with .bat files being LF in the large repo (they don't parse correctly), but the build/restore scripts are working fine here....
thinking


[*.{cs,cpp,h}]
indent_style = space
indent_size = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have an epic debate over the size of indentation and tabs/spaces before merging this in? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope :)

@derrickstolee derrickstolee added this to the Demo milestone Aug 13, 2019
@jrbriggs jrbriggs merged commit 64f333f into microsoft:master Aug 13, 2019
@jrbriggs jrbriggs deleted the convert-to-lf branch August 13, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants