[HOTFIX] Fix macOS build around Git installer package #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets around the multiple sources problem, but has the issue that every build will download the installers fresh. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
This copies a trick from .github/workflows/continuous-integration.yml to get the package version from the necessary place. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
fix-mac-build
branch
5 times, most recently
from
24b06d1
to
6b660d7
Compare
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
fix-mac-build
branch
from
6b660d7
to
a48b734
Compare
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
fix-mac-build
branch
from
c84c3ed
to
3104595
Compare
For some reason my best attempts to only pick the .pkg failed. Running the exacxt commands in my terminal worked. The side effect here is that we will start shipping the .dmg as well as the .pkg. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
fix-mac-build
branch
from
3104595
to
55fa7c5
Compare
jeffhostetler
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also fix the microsoft.scalar-release pipeline.
See #494 for the version into
main.After many attempts, I now have this working with the
microsoft.scalar-releasebuild in Azure Pipelines