Enable some more functional tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derrick Stolee <stolee@gmail.com>
|
Putting the tag back in to the |
wilbaker
approved these changes
Aug 13, 2019
Signed-off-by: Derrick Stolee <stolee@gmail.com>
derrickstolee
commented
Aug 13, 2019
| @@ -111,9 +111,8 @@ public static void Main(string[] args) | |||
|
|
|||
| // For now, run all of the tests not flagged as needing to be updated to work | |||
| // with the non-virtualized solution | |||
| includeCategories.Clear(); | |||
There was a problem hiding this comment.
@wilbaker I had do remove these .Clear() calls, since the excluded categories from above were super important on Mac. Specifically, the "no file based lock" one was needed to avoid tests that never completed.
jrbriggs
approved these changes
Aug 13, 2019
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Aug 15, 2020
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Aug 16, 2020
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Aug 16, 2020
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Aug 16, 2020
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Aug 17, 2020
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
chrisd8088
added a commit
to chrisd8088/scalar
that referenced
this pull request
Aug 17, 2020
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a test, but also resolves #39.
The mechanical rename also changed a bunch of strings in the test data that need to be reverted back to "GVFS" because we are using a test repo that contains those paths.
Expand the set of functional tests that we want to keep to include the background maintenance tests and the prefetch tests.