-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable some more functional tests #50
Enable some more functional tests #50
Conversation
Signed-off-by: Derrick Stolee <stolee@gmail.com>
Putting the tag back in to the |
Signed-off-by: Derrick Stolee <stolee@gmail.com>
@@ -111,9 +111,8 @@ public static void Main(string[] args) | |||
|
|||
// For now, run all of the tests not flagged as needing to be updated to work | |||
// with the non-virtualized solution | |||
includeCategories.Clear(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wilbaker I had do remove these .Clear()
calls, since the excluded categories from above were super important on Mac. Specifically, the "no file based lock" one was needed to avoid tests that never completed.
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
When the temporary clear() calls were removed from the functional test category lists in PR microsoft#50 (see commit 7e67496), this following block to re-exclude tests marked MacOnly became redundant, so we can remove it now.
This is mostly a test, but also resolves #39.
The mechanical rename also changed a bunch of strings in the test data that need to be reverted back to "GVFS" because we are using a test repo that contains those paths.
Expand the set of functional tests that we want to keep to include the background maintenance tests and the prefetch tests.