Update install #95
Update install #95
Conversation
|
|
||
| # Configure GCM | ||
| # GCM Core installer does not current configure itself properly in all scenarios | ||
| # Configure it here to ensure it is configured correctly |
There was a problem hiding this comment.
Can you explain more about how GCM Core isn't configured appropriately? I would lean towards fixing the config problem at the source if at all possible.
There was a problem hiding this comment.
I fixed one issue (we need to generate and consume a new GCM Core release to pick it up), but there are still other issues that @mjcheetham was working on. Similar to why we do this workaround in the VFS for Git upgrader for Mac as well. I will see if we have an open issue for this in GCM (@mjcheetham had provided details offline at one point)
There was a problem hiding this comment.
OK. That makes sense. Is there any concern about this applying to the wrong Git if this is the first time that our custom Git package has been installed and not on the PATH at the beginning of this script's execution?
There was a problem hiding this comment.
Is there any concern about this applying to the wrong Git if this is the first time that our custom Git package has been installed and not on the PATH at the beginning of this script's execution?
hmm... It looks like because we are running these with sudo, the config is being applied to the (correct) new git system. I am not sure exactly why this is /cc @jeffhost @nickgra in case they have any insight...
There was a problem hiding this comment.
I added another commit to clear Bash's hash of command paths so it will pick up the new git
There was a problem hiding this comment.
you could also do something like "git version | grep 2.22.0.vfs" or "/usr/local/bin/git version | grep ..."
and confirm that it reports the known version. and maybe add a "which git" and confirm that it is
the one we want.
The pattern of the Scalar distribution writing out a "driver" script sets environment variables and then calls another script can have issues when calling the driver script from a directory other than the one that contains the scripts. Instead, use a template for the installation script and set the desired configuration by token replacement, which should be more robust.
Several tweaks to the Scalar Distribution Installer:
More details can be found in the individual commit messages.