New cli argument allowing to specify receipt type to get after submission #212
+289
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarprudnikov
force-pushed
the
feat/specify-receipt-type-when-submitting-cose
branch
from
5371b03 to
81ffcd6
Compare
andpiccione
approved these changes
Aug 23, 2024
ivarprudnikov
deleted the
feat/specify-receipt-type-when-submitting-cose
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--receipt-typewith optionsraw(default),embedded, when callingsubmitaction to allow the download of the embedded receipt in one step without going throughembed-receiptcommand. This mitigates unwanted side effects whenembed-receiptlogic differs from the server logic; also, this will yield better user experience without the need to explain how to embed receipt in a separate step. It defaults torawto avoid any breaking surprises for those who use the cli already.get_last_embedded_receipt_from_cosewhich allows extracting the last receipt from a cose header. Used in receipt verification step when only signature with embedded receipt is provided.