Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use 6.0.0-dev* CCF releases #226

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Oct 18, 2024

The goal of this PR to set up a branch that uses the latest ccf-6.0.0 dev build (dev2).

  • changes needed for local builds with PLATFORM=virtual
  • updates to CI pipeline

The eventual goal is to get scitt-ccf-ledger to serve statements that are fully compliant with https://datatracker.ietf.org/doc/draft-ietf-scitt-architecture/09/.

Copy link
Member

@ivarprudnikov ivarprudnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change of the version needs more, please refer to the recent PR to see what needs to be done #223

Otherwise I do not understand why:

  • this was not done on the original branch?
  • this requires the change to v6?

More explanation in the PR would be great.

@achamayou
Copy link
Member Author

  • this was not done on the original branch?

Do you mean on main? I don't think this is ready for main yet, but eventually it's the goal.

  • this requires the change to v6?

Because 6.0.0 is when COSE signatures have been added. They are still in flux, especially until the RFC is finalised, and the change is quite substantial and does not the meet the "security and bug fixes" bar for LTS patches.

Copy link
Member

@andpiccione andpiccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since SGX is no longer support in this new CCF release, please make sure to update all the scripts and references where SGX is used as the default platform. There are references that have not been updated in this PR yet (e.g., run_functional_tests.sh, start.sh, build.sh, docker/build.sh, etc.)

.github/workflows/build-test.yml Show resolved Hide resolved
@achamayou
Copy link
Member Author

achamayou commented Oct 18, 2024

@andpiccione the SGX cleanup is not blocking 6.0.0 compatibility, or SCITT compliance, so I have ticketed it as #226. My goal on this branch is only to achieve SCITT compliance.

docs/reproducibility.md Show resolved Hide resolved
.github/workflows/build-test.yml Show resolved Hide resolved
@achamayou achamayou merged commit 2fa69f3 into microsoft:users/achamayou/cose-receipts Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants