Adds ASAN build to GH actions #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
reviewed
Nov 29, 2024
achamayou
reviewed
Nov 29, 2024
achamayou
reviewed
Nov 29, 2024
achamayou
reviewed
Nov 29, 2024
|
@ivarprudnikov we saw this in CCF too (microsoft/CCF#5118), and it was fixed by upgrading doctest, so this may be worth looking into. |
achamayou
approved these changes
Nov 29, 2024
…ot logs available
ivarprudnikov
force-pushed
the
feat/enable-address-sanitizer
branch
from
c50236d to
ebb8f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving disabled address sanitization ASAN as seen in https://github.com/microsoft/scitt-ccf-ledger/blob/044cd546914f86a0fe524223eaa1dbad50cf9f83/.pipelines/azure-pipelines.yml
This is similar to what CCF does https://github.com/microsoft/CCF/blob/main/.github/workflows/long-test.yml
ASAN depends on it being enabled in CCF (when using cmake functions
add_ccf_apporadd_san). For this CCF needs to be built from source with-DSANflag after which subsequent scitt ledger build will have ASAN enabled and ready to be evaluated through unit and functional tests.