Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CCF 6.0.0-dev18 #259

Merged
merged 5 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FROM ghcr.io/microsoft/ccf/app/dev/virtual:ccf-6.0.0-dev11
FROM ghcr.io/microsoft/ccf/app/dev/virtual:ccf-6.0.0-dev13
4 changes: 2 additions & 2 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
checks:
name: Format and License Checks
runs-on: ubuntu-20.04
container: ghcr.io/microsoft/ccf/app/dev/virtual:ccf-6.0.0-dev11
container: ghcr.io/microsoft/ccf/app/dev/virtual:ccf-6.0.0-dev13
steps:
- run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Checkout repository
Expand All @@ -37,7 +37,7 @@ jobs:
unit_tests_enabled: OFF
runs-on: ${{ matrix.platform.nodes }}
container:
image: ghcr.io/microsoft/ccf/app/dev/${{ matrix.platform.image }}:ccf-6.0.0-dev11
image: ghcr.io/microsoft/ccf/app/dev/${{ matrix.platform.image }}:ccf-6.0.0-dev13
options: ${{ matrix.platform.options }}
env:
# Helps to distinguish between CI and local builds.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
name: Analyze

runs-on: ubuntu-latest
container: ghcr.io/microsoft/ccf/app/dev/virtual:ccf-6.0.0-dev11
container: ghcr.io/microsoft/ccf/app/dev/virtual:ccf-6.0.0-dev13

permissions:
actions: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/long-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
name: fuzz
if: ${{ contains(github.event.pull_request.labels.*.name, 'run-fuzz-test') || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
runs-on: ubuntu-20.04
container: ghcr.io/microsoft/ccf/app/dev/virtual:ccf-6.0.0-dev11
container: ghcr.io/microsoft/ccf/app/dev/virtual:ccf-6.0.0-dev13
env:
PLATFORM: virtual
steps:
Expand Down
2 changes: 1 addition & 1 deletion .pipelines/pullrequest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ parameters: # parameters are shown up in ADO UI in a build queue time
- name: CCF_VERSION
displayName: Target CCF version to build for
type: string
default: 6.0.0-dev11
default: 6.0.0-dev13

variables:
SCITT_CI: 1 # used in scitt builds and tests
Expand Down
8 changes: 4 additions & 4 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ It is expected that you have Ubuntu 20.04. Follow the steps below to setup your

2. Install dependencies:
```sh
wget https://github.com/microsoft/CCF/archive/refs/tags/ccf-6.0.0-dev11.tar.gz
tar xvzf ccf-6.0.0-dev11.tar.gz
cd CCF-ccf-6.0.0-dev11/getting_started/setup_vm/
./run.sh app-dev.yml -e ccf_ver=6.0.0-dev11 -e platform=<virtual|snp> -e clang_version=15
wget https://github.com/microsoft/CCF/archive/refs/tags/ccf-6.0.0-dev13.tar.gz
tar xvzf ccf-6.0.0-dev13.tar.gz
cd CCF-ccf-6.0.0-dev13/getting_started/setup_vm/
./run.sh app-dev.yml -e ccf_ver=6.0.0-dev13 -e platform=<virtual|snp> -e clang_version=15
```

## Compiling
Expand Down
9 changes: 0 additions & 9 deletions app/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ project(scitt
set(COMPILE_TARGET "snp" CACHE STRING "Target compilation platform, either 'virtual', or 'snp'")
option(BUILD_TESTS "Whether to build tests" ON)
option(ENABLE_CLANG_TIDY "Run clang-tidy on the codebase" OFF)
# Added as option to enable Azure Linux build in 6.0.0-dev, will eventually be removed
# once the transition to libstdc++ is complete
set(USE_LIBCXX ON CACHE BOOL "Use libc++ instead of libstdc++")

set(CMAKE_EXPORT_COMPILE_COMMANDS ON)

find_package(ccf_${COMPILE_TARGET} 6.0.0 REQUIRED)
Expand Down Expand Up @@ -103,10 +99,6 @@ if (BUILD_TESTS)
add_subdirectory(${rapidcheck_SOURCE_DIR} ${rapidcheck_BINARY_DIR} EXCLUDE_FROM_ALL)
endif()

# Because CCF libraries are built with libc++,
# everything else has to be too.
target_compile_options(gtest PUBLIC ${COMPILE_LIBCXX})
target_compile_options(rapidcheck PUBLIC ${COMPILE_LIBCXX})
add_san(gtest)
add_san(rapidcheck)

Expand All @@ -122,7 +114,6 @@ if (BUILD_TESTS)
unit-tests/historical/lru_test.cpp
)
add_san(unit_tests)
target_compile_options(unit_tests PUBLIC ${COMPILE_LIBCXX})
target_link_system_libraries(unit_tests PRIVATE
GTest::gmock
rapidcheck
Expand Down
2 changes: 1 addition & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if [ "$PLATFORM" != "virtual" ] && [ "$PLATFORM" != "snp" ]; then
fi

if [ "$BUILD_CCF_FROM_SOURCE" = "ON" ]; then
CCF_SOURCE_VERSION="6.0.0-dev11"
CCF_SOURCE_VERSION="6.0.0-dev13"
echo "Cloning CCF sources"
rm -rf ccf-source
git clone --single-branch -b "ccf-${CCF_SOURCE_VERSION}" https://github.com/microsoft/CCF ccf-source
Expand Down
2 changes: 1 addition & 1 deletion docker/snp.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG CCF_VERSION=6.0.0-dev11
ARG CCF_VERSION=6.0.0-dev13
FROM ghcr.io/microsoft/ccf/app/dev/snp:ccf-${CCF_VERSION} as builder
ARG CCF_VERSION
ARG SCITT_VERSION_OVERRIDE
Expand Down
2 changes: 1 addition & 1 deletion docker/virtual.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG CCF_VERSION=6.0.0-dev11
ARG CCF_VERSION=6.0.0-dev13
FROM ghcr.io/microsoft/ccf/app/dev/virtual:ccf-${CCF_VERSION} as builder
ARG CCF_VERSION
ARG SCITT_VERSION_OVERRIDE
Expand Down
2 changes: 1 addition & 1 deletion pyscitt/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
python_requires=">=3.8",
install_requires=[
"ccf==6.0.0-dev11",
"ccf==6.0.0-dev13",
"cryptography==44.*", # needs to match ccf
"httpx",
"cbor2==5.4.*",
Expand Down
2 changes: 1 addition & 1 deletion test/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ httpx
pytest
loguru
aiotools
ccf==6.0.0-dev11
ccf==6.0.0-dev13
cryptography==44.*
jwcrypto==1.5.*
types-jwcrypto
Expand Down
Loading