.Net: Bug: Postgres SQL syntax error

[dluc]

Some input validation is missing, leading to syntax errors in the SQL generated.

Syntax errors could be avoided using named parameters (e.g. "@paramname").

This specific error could be avoided validating the model definition and informing the user with a specific validation exception. For instance, here the vector column is missing:

var def = new VectorStoreRecordDefinition
{
    Properties = new List<VectorStoreRecordProperty>
    {
        new VectorStoreRecordKeyProperty("Id", typeof(string)),
        new VectorStoreRecordDataProperty("Count", typeof(long))
    }
};

var collection = db.GetCollection<string, VectorStoreGenericDataModel<string>>("tests", def);
await collection.CreateCollectionAsync().ConfigureAwait(false);

var record = new VectorStoreGenericDataModel<string>("1");
record.Vectors["Count"] = 123;
await collection.UpsertAsync(record);

leading to this generic/proprietary exception:

Microsoft.Extensions.VectorData.VectorStoreOperationException: Call to vector store failed.
---> Npgsql.PostgresException (0x80004005): 42601: syntax error at or near ";"

[roji]

This specific error could be avoided validating the model definition and informing the user with a specific validation exception.

I think that with PostgreSQL (and some other providers) we actually support not having the vector populated (RequiresAtLeastOneVector = false), so this would be a validation problem, but rather a SQL generation bug.