.Net: Semantic Kernel dependency on .net 7.0 instead of 6.0 #2646
Comments
github-actions
bot
changed the title
|
@dmytrostruk - can you take a look into this? |
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 7, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves: #2646 As described in PR #1799, we should keep .NET packages at version 6.0.*, to support package compatibility and allow to use Azure Functions in-process deployment model. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Downgraded `System.Diagnostics.DiagnosticSource` package version from 7.0.2 to 6.0.0. 2. Manually tested telemetry functionality and verified that metering logic works as expected. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
github-project-automation
bot
moved this from Sprint: In Progress
to Sprint: Done
in Semantic Kernel
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this issue
Nov 1, 2023
…t#2746) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves: microsoft#2646 As described in PR microsoft#1799, we should keep .NET packages at version 6.0.*, to support package compatibility and allow to use Azure Functions in-process deployment model. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Downgraded `System.Diagnostics.DiagnosticSource` package version from 7.0.2 to 6.0.0. 2. Manually tested telemetry functionality and verified that metering logic works as expected. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The issue described in #1793 has been reintroduced in this commit:
55dc794
Mainly by adding dependency to the 7.0 version:
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="7.0.2" />The text was updated successfully, but these errors were encountered: