Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Bug: Vector Store search Score for Redis is mapped from wrong score field #9900

Closed
westey-m opened this issue Dec 6, 2024 · 0 comments
Closed

.Net: Bug: Vector Store search Score for Redis is mapped from wrong score field #9900

westey-m opened this issue Dec 6, 2024 · 0 comments
Assignees
@westey-m
Labels
bug Something isn't working memory connector .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@westey-m
Copy link
Contributor

westey-m commented Dec 6, 2024

Describe the bug
Vector Store search Score for Redis is mapped from the wrong score field.
It should be using the vector_score field and not the Score property on the result objects.
@westey-m westey-m added .NET Issue or Pull requests regarding .NET code bug Something isn't working memory connector sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) labels Dec 6, 2024
@westey-m westey-m self-assigned this Dec 6, 2024
@github-actions github-actions bot changed the title Bug: Vector Store search Score for Redis is mapped from wrong score field .Net: Bug: Vector Store search Score for Redis is mapped from wrong score field Dec 6, 2024
@westey-m westey-m mentioned this issue Dec 6, 2024
Open
@westey-m westey-m removed the triage label Dec 6, 2024
@westey-m westey-m moved this to Sprint: In Review in Semantic Kernel Dec 6, 2024
@westey-m westey-m mentioned this issue Dec 6, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 6, 2024
@westey-m
.Net: Fix bug where redis score was mapped from wrong score field. (#…
049cbbf 
…9901)

### Motivation and Context

#9900

### Description

Fixing mapping issue.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@westey-m westey-m moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Dec 6, 2024
@westey-m westey-m closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westey-m westey-m

Labels
bug Something isn't working memory connector .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markwallace-microsoft @westey-m