.Net: Update KernelFunctionInvokingChatClient as a specialization of MEAI.FunctionInvokingChatClient #11678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a specialization of it
…lated update changes needed
markwallace-microsoft
added
.NET
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
rogerbarreto
had a problem deploying
to
integration
GitHub Actions
Error
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
jeffhandley
reviewed
Apr 23, 2025
There was a problem hiding this comment.
@RogerBarret0 I left several comments for us to consider with @SteveSandersonMS.
Even if we don't make changes into MEAI GA for the possible API additions, the approach you've taken here to refactor the replacement classes out to keep the Kernel* classes more maintainable seems reasonable to me.
You also mentioned a middleware-type concept when we chatted, but I didn't spot where that was surfacing in here. Can you explain that again and/or draw my attention to it please?
dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/AIFunctionArgumentsV2.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/AIFunctionArgumentsV2.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/AIFunctionArgumentsV2.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/FunctionInvocationContextV2.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatClient/KernelFunctionInvokingChatClient.cs
Outdated
Show resolved
Hide resolved
…hub.com/rogerbarreto/semantic-kernel into issues/11628-functioninvoking-extension
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
rogerbarreto
added
needs discussion
rogerbarreto
changed the title
rogerbarreto
added
PR: ready for review
westey-m
reviewed
May 1, 2025
dotnet/src/Functions/Functions.OpenApi/RestApiOperationRunner.cs
Outdated
Show resolved
Hide resolved
This reverts commit f5847b9.
…t/semantic-kernel into issues/11628-functioninvoking-extension
SergeyMenshykh
approved these changes
May 1, 2025
.../SemanticKernel.Abstractions/Filters/AutoFunctionInvocation/AutoFunctionInvocationContext.cs
Outdated
Show resolved
Hide resolved
dmytrostruk
approved these changes
May 2, 2025
SergeyMenshykh
approved these changes
May 2, 2025
rogerbarreto
merged commit 9381c8d
into
microsoft:feature-msextensions-ai
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR introduces changes recently merged to MEAI which allow flexibility and reusage from the higher level implementation perspective of Semantic Kernel.
FYI @stephentoub @SteveSandersonMS