Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lint Workflow #123

Merged
merged 13 commits into from
Mar 24, 2023
Merged

Add Lint Workflow #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
64638d8
Adding ruff workflow
Mar 20, 2023
744a9d9
Fix repo path in lint.yml
Mar 20, 2023
f67f880
Fix another repo path in lint.yml
Mar 20, 2023
8d40eb2
cd to project root in install project
Mar 20, 2023
18cf897
Change pip install to poetry install
Mar 20, 2023
0f6df03
Change run command to poetry run
Mar 20, 2023
11d1e2f
cd to python in run lint
Mar 20, 2023
d876074
Fix path in run lint
Mar 20, 2023
df1387b
Add black check to lint
Mar 20, 2023
73ff789
Fix formatting issues
Mar 20, 2023
de7893e
Use suggestion
Mar 23, 2023
ad535c9
Use suggestion
Mar 23, 2023
0cd60f3
Merge branch 'python-preview' into python-preview
dluc Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Lint
on: push
# concurrency:
# group: lint-${{ github.ref }}
# cancel-in-progress: true

jobs:
ruff:
strategy:
fail-fast: false
matrix:
python-version: ["3.8"]
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
AdityaGudimella marked this conversation as resolved.
Show resolved Hide resolved
- run: echo "/root/.local/bin" >> $GITHUB_PATH
- uses: actions/checkout@v3
- name: Install poetry
run: pipx install poetry
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
cache: "poetry"
cache-dependency-path: "python/pyproject.toml"
- name: Install SemanticKernel
run: cd python && poetry install --no-ansi
- name: Run lint
run: cd python && poetry run ruff check .
black:
strategy:
fail-fast: false
matrix:
python-version: ["3.8"]
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
AdityaGudimella marked this conversation as resolved.
Show resolved Hide resolved
- run: echo "/root/.local/bin" >> $GITHUB_PATH
- uses: actions/checkout@v3
- name: Install poetry
run: pipx install poetry
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
cache: "poetry"
cache-dependency-path: "python/pyproject.toml"
- name: Install SemanticKernel
run: cd python && poetry install --no-ansi
- name: Run lint
run: cd python && poetry run black --check .
31 changes: 29 additions & 2 deletions python/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ pre-commit = "^2.21.0"
black = {version = "^23.1.0", allow-prereleases = true}
ipykernel = "^6.21.1"
pytest = "7.2.0"
ruff = "^0.0.257"

[tool.isort]
profile = "black"
Expand Down
1 change: 0 additions & 1 deletion python/semantic_kernel/core_skills/text_memory_skill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@


class TextMemorySkill:

COLLECTION_PARAM = "collection"
RELEVANCE_PARAM = "relevance"
KEY_PARAM = "key"
Expand Down