-
Notifications
You must be signed in to change notification settings - Fork 4.5k
.Net: Remove old MEVD integration tests #13484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+556
−9,321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westey-m
approved these changes
Jan 29, 2026
markwallace-microsoft
approved these changes
Jan 29, 2026
And port a few missing cases to the new compliance tests. Closes microsoft#12506
markwallace-microsoft
approved these changes
Jan 29, 2026
roji
added a commit
to roji/semantic-kernel
that referenced
this pull request
Jan 31, 2026
And port a few missing cases to the new compliance tests. Closes microsoft#12506
alzarei
added a commit
to alzarei/semantic-kernel
that referenced
this pull request
Feb 11, 2026
These tests were part of old MEVD integration tests removed in microsoft#13484. The fixtures they depend on were intentionally deleted as part of architectural cleanup. Coverage for vector stores continues via VectorData.ConformanceTests. ITextSearch interface testing continues via web connector tests. Resolves build failures from merge commit 948ffd6.
4 tasks
markwallace-microsoft
pushed a commit
that referenced
this pull request
Feb 11, 2026
…#13535) # fix: Remove obsolete ITextSearch vector store integration tests These tests were part of old MEVD integration tests removed in #13484. The fixtures they depend on were intentionally deleted as part of architectural cleanup. Coverage for vector stores continues via VectorData.ConformanceTests. ITextSearch interface testing continues via web connector tests. Resolves build failures from merge commit 948ffd6. ### Motivation and Context **1. Why is this change required?** The feature branch `feature-text-search-linq` is experiencing build failures after merging main (commit 948ffd6). CI/CD fails on all platforms with compilation errors preventing the branch from being merged to main. **2. What problem does it solve?** Resolves 3 compilation errors: - `QdrantVectorStoreFixture` not found - `AzureAISearchVectorStoreFixture` not found - Test files reference deleted fixtures **3. What scenario does it contribute to?** This fix enables the feature-text-search-linq branch to build successfully and proceed with the final merge to main. It aligns the branch with architectural changes made in #13484 where old MEVD integration tests were removed. **4. Related issues:** - Failed build: https://github.com/microsoft/semantic-kernel/actions/runs/21822919939/job/62960593139 - Related to #13484 (MEVD integration test cleanup) - Part of #13384 (feature branch PR) ### Description **Root Cause:** PR #13484 (merged Jan 29, 2026) removed old MEVD integration tests from main including test fixtures. PR #13179 (merged Oct 29, 2025) added ITextSearch integration tests to the feature branch that depend on those fixtures. When main was merged into the feature branch (commit 948ffd6), the test files were kept but the fixtures are gone, causing compilation errors. **Changes:** Removes 3 obsolete test files (328 deletions): - `dotnet/src/IntegrationTests/Connectors/Memory/AzureAISearch/AzureAISearchTextSearchTests.cs` - `dotnet/src/IntegrationTests/Connectors/Memory/Qdrant/QdrantTextSearchTests.cs` - `dotnet/src/IntegrationTests/Connectors/Memory/InMemory/InMemoryVectorStoreTextSearchTests.cs` **Rationale:** These tests should be removed because: 1. They test the deprecated `ITextSearch` interface (marked `[Obsolete]`), not the modern `ITextSearch<TRecord>` 2. They depend on fixtures intentionally deleted in #13484 architectural cleanup 3. Test coverage already exists elsewhere **Test Coverage Maintained Through:** - Vector store functionality: `dotnet/test/VectorData/*Connector*.ConformanceTests/` - VectorStoreTextSearch wrapper: `dotnet/src/SemanticKernel.UnitTests/Data/` - ITextSearch interface: `dotnet/src/IntegrationTests/Plugins/Web/` (Bing, Google, Tavily tests) **Impact:** No impact on the 6 PRs that comprise this feature branch (#13175, #13179, #13188, #13190, #13191, #13194). All implement the modern `ITextSearch<TRecord>` interface and are properly tested. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible (N/A - file removal only) - [x] I didn't break anyone 😄 (removes broken tests, no functionality changes) Co-authored-by: Alexander Zarei <alzarei@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And port a few missing cases to the new compliance tests.
Closes #12506