Copilot Chat: Feature/tesseract ocr Issue #1440 #1491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
TaoChenOSU
reviewed
Jun 16, 2023
samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/DocumentImportController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/DocumentImportController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/DocumentImportController.cs
Outdated
Show resolved
Hide resolved
teresaqhoang
added
the
PR: feedback to address
dehoward
reviewed
Jun 28, 2023
samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/DocumentImportController.cs
Outdated
Show resolved
Hide resolved
dehoward
reviewed
Jun 28, 2023
samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/DocumentImportController.cs
Outdated
Show resolved
Hide resolved
shawncal
changed the title
Remove TesseractOptions as this is no longer needed. Use a NullTesseractEngine if a language file isn't found or installed.
gitri-ms
requested changes
Jun 30, 2023
samples/apps/copilot-chat-app/webapp/src/assets/bot-icons/eviden-bot-icon-1.png
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/components/views/MissingEnvVariablesError.tsx
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/components/chat/ChatWindow.tsx
Outdated
Show resolved
Hide resolved
dehoward
reviewed
Jul 7, 2023
…round setting up lifetime management using IOptions.
This was referenced Jul 10, 2023
Contributor
|
Tested and will approve after the formatting warnings have been fixed. Great work, thank you very much! I have created a couple follow-up tasks to keep improving this amazing feature:
|
TaoChenOSU
added
PR: ready for review
dehoward
approved these changes
Jul 12, 2023
TaoChenOSU
approved these changes
Jul 12, 2023
gitri-ms
approved these changes
Jul 12, 2023
piotrek-appstream
pushed a commit
to Appstream-Studio/semantic-kernel
that referenced
this pull request
Jul 19, 2023
) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. (microsoft#1440) --> Extends the `copilot-chat-app` (https://github.com/microsoft/semantic-kernel/tree/9ba5c6b044e9697393e34129acf383c19b786d60/samples/apps/copilot-chat-app) sample to allow for importing images with text using the Tesseract library (https://github.com/charlesw/tesseract/) Issue: [Support Tesseract / OCR in Copilot Example microsoft#1440] ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Added a new "Tesseract" section within `appsettings.json` to specify Tesseract language file (eg: eng) Added corresponding `TesseractOptions` class and set up appropriate DI for use within the `DocumentImportController`. Added appropriate file extension mappings for common rasterized image formats: `png`, `jpg`, `tiff`. Updated frontend Web App to default to allowing these file extensions when selecting the File Import (paper clip icon) button. Added content to README.md within the `webapi` to explain usage. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. (microsoft#1440) --> Extends the `copilot-chat-app` (https://github.com/microsoft/semantic-kernel/tree/9ba5c6b044e9697393e34129acf383c19b786d60/samples/apps/copilot-chat-app) sample to allow for importing images with text using the Tesseract library (https://github.com/charlesw/tesseract/) Issue: [Support Tesseract / OCR in Copilot Example microsoft#1440] ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Added a new "Tesseract" section within `appsettings.json` to specify Tesseract language file (eg: eng) Added corresponding `TesseractOptions` class and set up appropriate DI for use within the `DocumentImportController`. Added appropriate file extension mappings for common rasterized image formats: `png`, `jpg`, `tiff`. Updated frontend Web App to default to allowing these file extensions when selecting the File Import (paper clip icon) button. Added content to README.md within the `webapi` to explain usage. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. (microsoft#1440) --> Extends the `copilot-chat-app` (https://github.com/microsoft/semantic-kernel/tree/9ba5c6b044e9697393e34129acf383c19b786d60/samples/apps/copilot-chat-app) sample to allow for importing images with text using the Tesseract library (https://github.com/charlesw/tesseract/) Issue: [Support Tesseract / OCR in Copilot Example microsoft#1440] ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Added a new "Tesseract" section within `appsettings.json` to specify Tesseract language file (eg: eng) Added corresponding `TesseractOptions` class and set up appropriate DI for use within the `DocumentImportController`. Added appropriate file extension mappings for common rasterized image formats: `png`, `jpg`, `tiff`. Updated frontend Web App to default to allowing these file extensions when selecting the File Import (paper clip icon) button. Added content to README.md within the `webapi` to explain usage. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com>
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. (microsoft#1440) --> Extends the `copilot-chat-app` (https://github.com/microsoft/semantic-kernel/tree/9ba5c6b044e9697393e34129acf383c19b786d60/samples/apps/copilot-chat-app) sample to allow for importing images with text using the Tesseract library (https://github.com/charlesw/tesseract/) Issue: [Support Tesseract / OCR in Copilot Example microsoft#1440] ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Added a new "Tesseract" section within `appsettings.json` to specify Tesseract language file (eg: eng) Added corresponding `TesseractOptions` class and set up appropriate DI for use within the `DocumentImportController`. Added appropriate file extension mappings for common rasterized image formats: `png`, `jpg`, `tiff`. Updated frontend Web App to default to allowing these file extensions when selecting the File Import (paper clip icon) button. Added content to README.md within the `webapi` to explain usage. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: Tao Chen <TaoChenOSU@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Extends the
copilot-chat-app(https://github.com/microsoft/semantic-kernel/tree/9ba5c6b044e9697393e34129acf383c19b786d60/samples/apps/copilot-chat-app) sample to allow for importing images with text using the Tesseract library (https://github.com/charlesw/tesseract/)Issue: [Support Tesseract / OCR in Copilot Example #1440]
Description
Added a new "Tesseract" section within
appsettings.jsonto specify Tesseract language file (eg: eng)Added corresponding
TesseractOptionsclass and set up appropriate DI for use within theDocumentImportController.Added appropriate file extension mappings for common rasterized image formats:
png,jpg,tiff.Updated frontend Web App to default to allowing these file extensions when selecting the File Import (paper clip icon) button.
Added content to README.md within the
webapito explain usage.Contribution Checklist
dotnet format