-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Add Meter to Kernel #1969
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrostruk
reviewed
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This pull request addresses the need for metrics support in the Semantic Kernel library.
Why is this change required? - Metrics are essential for monitoring the performance and overall health of applications. They provide insights to understand system behavior in production, and they allow us to identify and troubleshoot issues before they impact users. However, the Semantic Kernel library currently lacks built-in metrics support.
What problem does it solve? - This PR adds metrics support to the Semantic Kernel library, allowing users to monitor the library's performance and usage in their applications.
What scenario does it contribute to? - This feature will be particularly useful in scenarios where users need to analyze the usage and performance of the Semantic Kernel library in their applications. This could include tracking how often certain features are used, how long operations take, or how often errors occur.
Linked Issue - Related to issue Feature Request: Add Metrics Support via .NET's Built-In
Meter
to Semantic Kernel Library #1966 .Description
This PR adds support for the .NET
System.Diagnostics.Metrics.Meter
API in the Semantic Kernel library. A newwithMeter(Meter meter)
method has been added to theBuilder
class, allowing users to pass in a customMeter
instance when configuring the Semantic Kernel library.In the Semantic Kernel library code, this
Meter
is used to create and update metrics. Currently, a simple counter named "my-counter" is created as an example. Users can use aMeterListener
to listen to these metrics and export them to their desired backend.The overall design follows the common pattern of passing a
Meter
to the components that need to record metrics, allowing these components to remain decoupled from the specifics of metric collection and export.Contribution Checklist
dotnet format