.Net: Issue-2839: Fixed .NET notebook '07-DALL-E-2' errors #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed embedding compare code in .NET notebook 07
github-actions
bot
changed the title
markwallace-microsoft
approved these changes
Oct 4, 2023
dmytrostruk
approved these changes
Oct 4, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
…#3065) ### Motivation and Context Running the .NET notebook '07-DALL-E-2' using OpenAI had 2 errors breaking the experience for new developers. ### Description 1. The configuration attempted to use the **chat** mode 'gpt-3.5-turbo' but with a **Text** completion service. This was fixed by changing the model to 'text-davinci-003' (as is stated in the description above the code box anyway). 2. The embedding comparison code used an extension 'AsReadOnlySpan()' which does not exist for a ReadOnlyMemory<float> which is what is returned by the OpenAI Embedding Generation Service. Fix this by changing it to just access the 'span' that already exists on the ReadOnlyMemory<float> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Running the .NET notebook '07-DALL-E-2' using OpenAI had 2 errors breaking the experience for new developers.
Description
The configuration attempted to use the chat mode 'gpt-3.5-turbo' but with a Text completion service. This was fixed by changing the model to 'text-davinci-003' (as is stated in the description above the code box anyway).
The embedding comparison code used an extension 'AsReadOnlySpan()' which does not exist for a ReadOnlyMemory which is what is returned by the OpenAI Embedding Generation Service. Fix this by changing it to just access the 'span' that already exists on the ReadOnlyMemory
Contribution Checklist